gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL]
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289259910
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetLogRedirector.java
##########
@@ -25,11 +25,11 @@
// Redirects the JUL logging for parquet-mr versions <= 1.8 to SLF4J logging
using
// SLF4JBridgeHandler. Parquet-mr versions >= 1.9 use SLF4J directly
-final class ParquetLogRedirector implements Serializable {
+public final class ParquetLogRedirector implements Serializable {
Review comment:
> Spark uses Parquet >= 1.9. Is this still needed?
I am not sure about this. I think we can resolve this in another Jira/PR.
> Why was it made public?
We need to make it public so that ParquetWriteBuilder can access it. As per
the discussion in https://issues.apache.org/jira/browse/SPARK-16964, I think it
is fine to do this in the `sql.execution` package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
