Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3607#discussion_r22593068
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala ---
    @@ -38,24 +38,30 @@ private[spark] class ClientArguments(args: 
Array[String], sparkConf: SparkConf)
       var amMemory: Int = 512 // MB
       var appName: String = "Spark"
       var priority = 0
    +  var isClusterMode = false
    +
    +  private val driverMemKey = "spark.driver.memory"
    +  private val driverMemOverheadKey = "spark.yarn.driver.memoryOverhead"
    +  private val amMemKey = "spark.yarn.am.memory"
    +  private val amMemOverheadKey = "spark.yarn.am.memoryOverhead"
    +  private var isDriverMemSet = false
     
       parseArgs(args.toList)
     
    +  private val isDynamicAllocationEnabled =
    +    sparkConf.getBoolean("spark.dynamicAllocation.enabled", false)
    +
    +  loadEnvironmentArgs()
    +  validateArgs()
    +
       // Additional memory to allocate to containers
    -  // For now, use driver's memory overhead as our AM container's memory 
overhead
       val amMemoryOverhead = 
sparkConf.getInt("spark.yarn.driver.memoryOverhead",
         math.max((MEMORY_OVERHEAD_FACTOR * amMemory).toInt, 
MEMORY_OVERHEAD_MIN))
     
       val executorMemoryOverhead = 
sparkConf.getInt("spark.yarn.executor.memoryOverhead",
         math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt, 
MEMORY_OVERHEAD_MIN))
     
    -  private val isDynamicAllocationEnabled =
    -    sparkConf.getBoolean("spark.dynamicAllocation.enabled", false)
    -
    -  loadEnvironmentArgs()
    -  validateArgs()
    -
    -  /** Load any default arguments provided through environment variables 
and Spark properties. */
    +   /** Load any default arguments provided through environment variables 
and Spark properties. */
    --- End diff --
    
    unnecessarily indented


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to