mengxr commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r289461703
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala
##########
@@ -35,5 +41,7 @@ private[cluster] class ExecutorData(
var freeCores: Int,
override val totalCores: Int,
override val logUrlMap: Map[String, String],
- override val attributes: Map[String, String]
-) extends ExecutorInfo(executorHost, totalCores, logUrlMap, attributes)
+ override val attributes: Map[String, String],
+ override val totalResources: Map[String, ResourceInformation],
+ val availableResources: mutable.Map[String, ExecutorResourceInfo]
Review comment:
Does it need to be mutable? I don't find any operation that changes it in
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
