jiangxb1987 commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling URL: https://github.com/apache/spark/pull/24374#discussion_r289584437
########## File path: core/src/main/scala/org/apache/spark/scheduler/InternalExecutorResourcesInfo.scala ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.scheduler + + +/** + * Internal class to expose executor resources information to TaskScheduler from SchedulerBackend, + * while also ensure the TaskScheduler will not modify the executor resources information. + * Idealy we shall keep a copy of the map from resource name to resource addresses inside this + * class, but the deep copy can be time consuming when you have many executors, so we just keep + * the copy inside class ExecutorResourceInfo. + */ +private[scheduler] class InternalExecutorResourcesInfo( + private val resources: Map[String, ExecutorResourceInfo]) extends Serializable { + + // Reset all the buffered addresses. + resources.values.foreach(_.resetIdleAddresses()) Review comment: removed the function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
