dongjoon-hyun commented on issue #24747: [SPARK-27772][SQL][TEST] SQLTestUtils Refactoring URL: https://github.com/apache/spark/pull/24747#issuecomment-497916778 @William1104 . Please note that the code clearly describes the reason of decision why we ignore `NoSuchTableException` in `withTempView` in the comment. It mentioned what exception is targeted and should be ignored. Why do you think it is hard? > I believe it is not the best approach. Because it is hard to anticipate what exception should or should not be ignored. In general, I really thank you for trying to improve in many ways. However, the PR title and description looks outdate now. The complexity of proposed code goes higher and higher. The current suggested code doesn't look better in the context of the existing functions. For me, the existing ones looks more simpler with a clear meaning which is intentionally designed to ignore the only relevant exceptions. How do you think about that?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
