srowen commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289603757
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetLogRedirector.java
##########
@@ -25,11 +25,11 @@
// Redirects the JUL logging for parquet-mr versions <= 1.8 to SLF4J logging
using
// SLF4JBridgeHandler. Parquet-mr versions >= 1.9 use SLF4J directly
-final class ParquetLogRedirector implements Serializable {
+public final class ParquetLogRedirector implements Serializable {
Review comment:
Hm, I think we can stop supporting Parquet 1.6 already. I'm not sure why
this still references 1.6.0 vs `parquet.version`. I presume we get away with it
because it's the com.twitter parquet and it's shaded or something? maybe it's
required for Hadoop 2.x support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
