William1104 edited a comment on issue #24747: [SPARK-27772][SQL][TEST] SQLTestUtils Refactoring URL: https://github.com/apache/spark/pull/24747#issuecomment-497934010 > Hi @dongjoon-hyun and @srowen , understood the concern and I will revert the logic to ignore those given exception. > > Btw, the build is failing in many unexpected test cases. I will check further. The comment of the `withTempView` function sounds like the author would like to ignore `NoSucTableException` within the foreach loop, but not outside the foreach loop. Maybe it is out of the scope of this PR, but it looks like the finally block of this function should be ``` viewNames.foreach { viewName => try spark.catalog.dropTempView(viewName) catch { // If the test failed part way, we don't want to mask the failure by failing to remove // temp views that never got created. case _: NoSuchTableException => } } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
