srowen commented on a change in pull request #24764: [SPARK-18570][ML] RFormula
support * and ^ operators
URL: https://github.com/apache/spark/pull/24764#discussion_r289621200
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
##########
@@ -297,13 +315,15 @@ class RFormula @Since("1.5.0") (@Since("1.5.0") override
val uid: String)
@Since("1.5.0")
// optimistic schema; does not contain any ML attributes
override def transformSchema(schema: StructType): StructType = {
- require(!hasLabelCol(schema) || !$(forceIndexLabel),
+ require(
+ !hasLabelCol(schema) || ! $(forceIndexLabel),
Review comment:
Likewise around here I wouldn't reformat; it's pretty fine or at least
consistent with the rest of the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
