mallman commented on a change in pull request #24327: [SPARK-27418][SQL]
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289651414
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetLogRedirector.java
##########
@@ -25,11 +25,11 @@
// Redirects the JUL logging for parquet-mr versions <= 1.8 to SLF4J logging
using
// SLF4JBridgeHandler. Parquet-mr versions >= 1.9 use SLF4J directly
-final class ParquetLogRedirector implements Serializable {
+public final class ParquetLogRedirector implements Serializable {
Review comment:
Hi @gengliangwang. I won't be able to help you with this, no. I don't have
access to the environment or data necessary for testing, and I cannot make time
for the PR. Sorry to disappoint.
Regardless, I suggest just deleting this code as part of this PR. Given that
Spark is now using Parquet 1.10.1, and the fact that Parquet 1.9+ logs with
SLF4J directly, I think deleting this code is low-enough risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
