rdblue commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate 
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289659563
 
 

 ##########
 File path: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetLogRedirector.java
 ##########
 @@ -25,11 +25,11 @@
 
 // Redirects the JUL logging for parquet-mr versions <= 1.8 to SLF4J logging 
using
 // SLF4JBridgeHandler. Parquet-mr versions >= 1.9 use SLF4J directly
-final class ParquetLogRedirector implements Serializable {
+public final class ParquetLogRedirector implements Serializable {
 
 Review comment:
   `hive.parquet.version` sets the version of Parquet used by Hive, when Spark 
is wrapping a table and using Hive readers. This doesn't affect either the v1 
Parquet data source or the v2 source. This may still be necessary for Hive 
reads, but I don't think it needs to be carried forward to v2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to