dongjoon-hyun commented on issue #24747: [SPARK-27772][SQL][TEST] Refactor SQLTestUtils to use `tryWithSafeFinally` URL: https://github.com/apache/spark/pull/24747#issuecomment-498075923 @William1104 . May I ask three things in the PR description? - I think we can remove the following because this is not related much. > Java's try-with-resources statement does something similar, but it does not mask exception throwing in the try block with any exception caught in the 'close()' statement. Exception caught in the 'close()' statement would add as a suppressed exception instead. - Instead, please describe why you choose `Utils.tryWithSafeFinally` clearly. To me, the sentence `does something similar` hides your idea. > Utils.tryWithSafeFinally function, which does something similar to Java's try-with-resources statement. - Finally, please describe how your PR help the developer by example. What is the exact example during using `withXXX` functions? > The purpose of this proposal is to help developers to identify what actually breaks their tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
