dongjoon-hyun commented on a change in pull request #24723: [SPARK-27857][SQL]
Move ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r289662569
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -17,17 +17,29 @@
package org.apache.spark.sql.catalyst.parser
+import java.util.Locale
+
import org.apache.spark.sql.catalog.v2.expressions.{ApplyTransform,
BucketTransform, DaysTransform, FieldReference, HoursTransform,
IdentityTransform, LiteralValue, MonthsTransform, YearsTransform}
import org.apache.spark.sql.catalyst.analysis.AnalysisTest
import org.apache.spark.sql.catalyst.catalog.BucketSpec
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
-import
org.apache.spark.sql.catalyst.plans.logical.sql.{CreateTableAsSelectStatement,
CreateTableStatement, DropTableStatement, DropViewStatement}
-import org.apache.spark.sql.types.{IntegerType, StringType, StructType,
TimestampType}
+import
org.apache.spark.sql.catalyst.plans.logical.sql.{AlterTableAddColumnsStatement,
AlterTableAlterColumnStatement, AlterTableDropColumnsStatement,
AlterTableRenameColumnStatement, AlterTableSetLocationStatement,
AlterTableSetPropertiesStatement, AlterTableUnsetPropertiesStatement,
AlterViewSetPropertiesStatement, AlterViewUnsetPropertiesStatement,
CreateTableAsSelectStatement, CreateTableStatement, DropTableStatement,
DropViewStatement, NewColumn}
+import org.apache.spark.sql.types.{IntegerType, LongType, StringType,
StructType, TimestampType}
import org.apache.spark.unsafe.types.UTF8String
class DDLParserSuite extends AnalysisTest {
import CatalystSqlParser._
+ private def assertUnsupported(sql: String, containsThesePhrases: Seq[String]
= Seq()): Unit = {
Review comment:
~Is it inevitable to duplicate this utility functions during refactoring?~
Sorry, I realized that this is not the same at line 35.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
