Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/3710#issuecomment-69100998
  
    Hi @zsxwing the changes look reasonable. My comments are mainly minor 
wording suggestions and clarifications. One thing is that we can save the 
refactoring of `StreamingListenerBus` to extend `SparkListenerBus` for a 
separate PR, but in this PR I would prefer the behavior of 
`StreamingListenerBus` to match that of the `LiveListenerBus`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to