Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3923#discussion_r22623086
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/impl/MultivariateGaussian.scala
---
@@ -30,22 +31,57 @@ import org.apache.spark.mllib.util.MLUtils
* @param mu The mean vector of the distribution
* @param sigma The covariance matrix of the distribution
*/
-private[mllib] class MultivariateGaussian(
+class MultivariateGaussian private[mllib] (
val mu: DBV[Double],
val sigma: DBM[Double]) extends Serializable {
--- End diff --
I'd add a check here to make sure that the dimensions of mu, sigma match up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
