gatorsmile commented on a change in pull request #24776: [SPARK-27926][SQL]
Allow altering table add columns with CSVFileFormat/JsonFileFormat provider
URL: https://github.com/apache/spark/pull/24776#discussion_r290060662
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -238,7 +240,8 @@ case class AlterTableAddColumnsCommand(
// TextFileFormat only default to one column "value"
// Hive type is already considered as hive serde table, so the logic
will not
// come in here.
- case _: JsonDataSourceV2 | _: CSVDataSourceV2 | _: ParquetFileFormat |
_: OrcDataSourceV2 =>
+ case _: CSVFileFormat | _: JsonFileFormat | _: ParquetFileFormat =>
+ case _: JsonDataSourceV2 | _: CSVDataSourceV2 | _: OrcDataSourceV2 =>
Review comment:
These V2 data sources also support ADD COLUMNs? Do we have the test cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
