vanzin commented on a change in pull request #24554: [SPARK-27622][Core]
Avoiding the network when block manager fetches disk persisted RDD blocks from
the same host
URL: https://github.com/apache/spark/pull/24554#discussion_r290075045
##########
File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
##########
@@ -1310,6 +1309,24 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
assert(Utils.trimExceptCRLF(s"b${s}b") === s"b${s}b")
}
}
+
+ test("deleting an already opened file does not interrupt the reading
process") {
Review comment:
Not sure why you're adding this test? That's standard posix behavior. (On
Windows the delete might fail but the read should still work.)
If you're adding this as a proof that this actually works so that the
feature you're adding doesn't break, then that should be explained. But in that
case I'd just put a big comment in the part of the code that might be affected
by this and skip this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
