LantaoJin commented on a change in pull request #24774: [SPARK-27899][SQL] Make
HiveMetastoreClient.getTableObjectsByName available in
ExternalCatalog/SessionCatalog API
URL: https://github.com/apache/spark/pull/24774#discussion_r290081905
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -434,6 +434,22 @@ class SessionCatalog(
externalCatalog.getTable(db, table)
}
+ /**
+ * Retrieve the metadata of an existing permanent table/view. If no database
is specified,
+ * assume the table/view is in the current database.
+ */
+ @throws[NoSuchDatabaseException]
+ def getTablesByName(names: Seq[TableIdentifier]): Seq[CatalogTable] = {
+ if (names.nonEmpty) {
+ val db =
formatDatabaseName(names.head.database.getOrElse(getCurrentDatabase))
Review comment:
I have considered this case. Could this be happened in the reality use
cases? But good catch, it should be handled in code. How about throws an
exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
