gengliangwang commented on a change in pull request #24787: [MINOR] [DOC] Avro
data source documentation change
URL: https://github.com/apache/spark/pull/24787#discussion_r290129130
##########
File path: docs/sql-data-sources-avro.md
##########
@@ -199,7 +199,7 @@ Data source options of Avro can be set via:
<td><code>avroSchema</code></td>
<td>None</td>
<td>Optional Avro schema provided by a user in JSON format. The date type
and naming of record fields
- should match the input Avro data or Catalyst data, otherwise the
read/write action will fail.</td>
+ should match the input Avro data or Spark's internal data type (e.g.,
StringType, IntegerType)., otherwise the read/write action will fail.</td>
Review comment:
+1 with @gatorsmile , we can also remove the second "should".
```
should match the Avro data type when reading from Avro or match the Spark's
internal data type (e.g., StringType, IntegerType) when writing to Avro files;
otherwise, the read/write action will fail.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
