hvanhovell commented on a change in pull request #24761: [SPARK-27905] [SQL]
Add higher order function 'forall'
URL: https://github.com/apache/spark/pull/24761#discussion_r290172464
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -2320,6 +2320,107 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSQLContext {
assert(ex4.getMessage.contains("cannot resolve '`a`'"))
}
+ test("forall function - array for primitive type not containing null") {
Review comment:
I think most/all of this should be covered by unit tests. You can add a
single test to validate that the function registry works, if you must. I know
you mirrored the tests for `exists` and I think they have the same problem. In
general we should test the interface here (including the errors), and not so
much the underlying functionality (that should be covered by UTs).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
