dvogelbacher commented on a change in pull request #24677:
[SPARK-27805][PYTHON] Propagate SparkExceptions during toPandas with arrow
enabled
URL: https://github.com/apache/spark/pull/24677#discussion_r290390863
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -3313,20 +3313,34 @@ class Dataset[T] private[sql](
}
}
- val arrowBatchRdd = toArrowBatchRdd(plan)
- sparkSession.sparkContext.runJob(
- arrowBatchRdd,
- (it: Iterator[Array[Byte]]) => it.toArray,
- handlePartitionBatches)
+ var sparkException: Option[SparkException] = None
+ try {
+ val arrowBatchRdd = toArrowBatchRdd(plan)
+ sparkSession.sparkContext.runJob(
+ arrowBatchRdd,
+ (it: Iterator[Array[Byte]]) => it.toArray,
+ handlePartitionBatches)
+ } catch {
+ case e: SparkException =>
+ sparkException = Some(e)
+ }
- // After processing all partitions, end the stream and write batch
order indices
+ // After processing all partitions, end the batch stream
batchWriter.end()
Review comment:
Any more thoughts on this @BryanCutler ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
