revans2 commented on issue #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing URL: https://github.com/apache/spark/pull/24795#issuecomment-499111008 @rxin we don't need a ColumnarRule. It just made the code simpler. I see your point and I am happy to change it if you like. I can do separate registration for pre/post rules, or I can just have them be internal to ColumnarRule. ``` class ColumnarRule { def pre: Rule[SparkPlan] = plan => plan def post: Rule[SparkPlan] = plan => plan } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
