rdblue commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2: Select from multiple catalogs
URL: https://github.com/apache/spark/pull/24741#discussion_r290843104
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -185,6 +186,8 @@ abstract class BaseSessionStateBuilder(
V2WriteSupportCheck +:
V2StreamingScanSupportCheck +:
customCheckRules
+
+ override protected def lookupCatalog(name: String): CatalogPlugin =
session.catalog(name)
Review comment:
#24768 passes a single LookupCatalog (the analyzer), as you suggested in the
other comment. I like using the same lookup everywhere instead of having
multiple classes implement LookupCatalog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
