Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/3939#discussion_r22636258
--- Diff: ec2/spark_ec2.py ---
@@ -983,6 +969,12 @@ def real_main():
(opts, action, cluster_name) = parse_args()
# Input parameter validation
+ if "." in opts.spark_version:
--- End diff --
Minor comment: Since we do this spark_version.replace("v", "") in two
places it might make sense to keep the old function but name it as
`get_spark_version` (or `check_get_spark_version`). You can then call it once
here and once while constructing the template variables
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
