gatorsmile commented on issue #24802: [SPARK-27949][SQL]Support ANSI SQL grammar `substring(string_expression from n1 [for n2])` URL: https://github.com/apache/spark/pull/24802#issuecomment-499573033 This PR is not to implement/change the actual execution of substring. The changes made in the parser look fine to me. @lipzhu Please address the minor comments. I would merge it as long as you fix them. https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/bit.sql also has the test cases to cover this new support. When we port these tests, we will have better test coverage on this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
