rdblue commented on a change in pull request #24812: [SPARK-27965][SQL] Add extractors for v2 catalog transforms. URL: https://github.com/apache/spark/pull/24812#discussion_r291273042
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalog/v2/expressions/TransformExtractorSuite.scala ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalog.v2.expressions + +import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.catalyst +import org.apache.spark.sql.types.DataType + +class TransformExtractorSuite extends SparkFunSuite { + /** + * Creates a Literal using an anonymous class. + */ + private def lit[T](literal: T): Literal[T] = new Literal[T] { + override def value: T = literal + override def dataType: DataType = catalyst.expressions.Literal(literal).dataType + override def describe: String = literal.toString + } + + /** + * Creates a NamedReference using an anonymous class. + */ + private def ref(names: String*): NamedReference = new NamedReference { + override def fieldNames: Array[String] = names.toArray + override def describe: String = names.mkString(".") + } + + /** + * Creates a Transform using an anonymous class. + */ + def transform(func: String, ref: NamedReference): Transform = new Transform { + override def name: String = func + override def references: Array[NamedReference] = Array(ref) + override def arguments: Array[Expression] = Array(ref) + override def describe: String = ref.describe + } + + /** + * Creates a bucket Transform using an anonymous class. + */ + def bucket(numBuckets: Int, ref: NamedReference): Transform = new Transform { + override def name: String = "bucket" + override def references: Array[NamedReference] = Array(ref) + override def arguments: Array[Expression] = Array(lit(numBuckets), ref) + override def describe: String = ref.describe + } Review comment: Moved into the bucket test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
