dongjoon-hyun commented on a change in pull request #24815: [SPARK-27961][SQL]
DataSourceV2Relation should not have refresh method
URL: https://github.com/apache/spark/pull/24815#discussion_r291424651
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/MetadataCacheSuite.scala
##########
@@ -57,13 +56,20 @@ abstract class MetadataCacheSuite extends QueryTest with
SharedSQLContext {
df.count()
}
assert(e.getMessage.contains("FileNotFoundException"))
- assert(e.getMessage.contains("REFRESH"))
+ assert(e.getMessage.contains("recreating the Dataset/DataFrame
involved"))
}
}
+}
+
+class MetadataCacheV1Suite extends MetadataCacheSuite {
+ override protected def sparkConf: SparkConf =
+ super
+ .sparkConf
+ .set(SQLConf.USE_V1_SOURCE_READER_LIST, "orc")
test("SPARK-16337,SPARK-27504 temporary view refresh") {
Review comment:
`SPARK-27504` had better be removed like
[this](https://github.com/apache/spark/pull/24815/files#diff-0667b59236ca014a47b3fc20b6ea820eR41)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
