viirya commented on a change in pull request #24806: [SPARK-27856][SQL] Only
allow type upcasting when inserting table
URL: https://github.com/apache/spark/pull/24806#discussion_r291441249
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala
##########
@@ -81,6 +81,7 @@ class HiveSessionStateBuilder(session: SparkSession,
parentState: Option[Session
RelationConversions(conf, catalog) +:
PreprocessTableCreation(session) +:
PreprocessTableInsertion(conf) +:
+ ResolveUpCast +:
Review comment:
Is it good to add a comment like `BaseSessionStateBuilder`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
