viirya commented on a change in pull request #24814: set Int MaxValue
URL: https://github.com/apache/spark/pull/24814#discussion_r291646019
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala
##########
@@ -233,7 +233,7 @@ class Word2Vec extends Serializable with Logging {
a += 1
}
while (a < 2 * vocabSize) {
- count(a) = 1e9.toInt
+ count(a) = Int.MaxValue
Review comment:
For reference, in an early implementation of word2vec, it uses 1e15:
https://github.com/tmikolov/word2vec/blob/master/word2vec.c#L214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
