srowen commented on a change in pull request #24702: [Minor] [Kubernetes]
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r291669328
##########
File path:
core/src/test/scala/org/apache/spark/executor/CoarseGrainedExecutorBackendSuite.scala
##########
@@ -224,6 +223,30 @@ class CoarseGrainedExecutorBackendSuite extends
SparkFunSuite
}
}
+ test("number of retries is respected when always failing") {
+
Review comment:
I just don't think this test or method is worthwhile. It's more or less
verifying you've simulated a for loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
