dongjoon-hyun commented on issue #24749: [SPARK-27890][SQL] Improve SQL parser error message for character-only identifier with hyphens except those in expressions URL: https://github.com/apache/spark/pull/24749#issuecomment-500053088 Hi, @yeshengm . In general, to be merged, the PR had better be complete and consistent at least in terms of four dimensions, the PR title/description/code/test coverage, along the scope of the PR. Could you check the PR again? Since this is your proposal, it's up to you. Please don't expect the reviewers give you a complete code for you. We can give a guideline only.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
