Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3947#issuecomment-69157174
I'm not sure about most of these.
- Why is tempDir a field?
- _ is more idiomatic in Scala than null for a reference field's default
value.
- Why remove the call to disconnect? almost seems like it should be in a
finally block
- The regex change alters the functionality. I think "word count" examples
across the world split on space.
- It's probably fine to resume one MqttMessage int he loop but are you sure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
