jlpedrosa commented on a change in pull request #24702: [Minor] [Kubernetes]
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r291815473
##########
File path:
core/src/test/scala/org/apache/spark/executor/CoarseGrainedExecutorBackendSuite.scala
##########
@@ -224,6 +223,30 @@ class CoarseGrainedExecutorBackendSuite extends
SparkFunSuite
}
}
+ test("number of retries is respected when always failing") {
+
Review comment:
It tests mainly two things: 1) That you indeed go n times, and 2) the
behaviour of throwing the exception. I can change it if you want, for sure
there is not performance difference and I think it will be actually less lines
of code than the try catch and the if statements.
@srowen let me know if you want me to go to the iterative approach.
Once you confirm me this. Should I rebase with the changes? I'm not familiar
with the process in apache. After the review it will be accepted or there are
more steps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
