cloud-fan commented on a change in pull request #24806: [SPARK-27856][SQL] Only
allow type upcasting when inserting table
URL: https://github.com/apache/spark/pull/24806#discussion_r291824567
##########
File path:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
##########
@@ -59,6 +59,8 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with
BeforeAndAfter {
TestHive.setConf(SQLConf.IN_MEMORY_PARTITION_PRUNING, true)
// Ensures that cross joins are enabled so that we can test them
TestHive.setConf(SQLConf.CROSS_JOINS_ENABLED, true)
+ // Force type case during table insertion
+ TestHive.setConf(SQLConf.LEGACY_INSERT_TABLE_TYPE_COERCION, true)
Review comment:
This test is to make sure Spark has the same behavior with Hive, however
Hive always add unsafe cast, so we need to turn on this config to make tests
pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
