dongjoon-hyun commented on a change in pull request #24782: [SPARK-27934][SQL] Port case.sql URL: https://github.com/apache/spark/pull/24782#discussion_r291824886
########## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/case.sql ########## @@ -0,0 +1,267 @@ +-- +-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group +-- +-- +-- CASE +-- https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/case.sql +-- Test the case statement +-- +-- There are 2 join condition is missing in this test case. we set spark.sql.crossJoin.enabled=true. Review comment: - `is missing` -> `which is missing` or `missed`? - `we set` -> `We set`. BTW, it's not clear about the relation between the missed one and `crossJoin`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
