dongjoon-hyun commented on a change in pull request #24802: [SPARK-27949][SQL] 
Support ANSI SQL grammar `SUBSTRING(str FROM n1 [FOR n2])`
URL: https://github.com/apache/spark/pull/24802#discussion_r291883483
 
 

 ##########
 File path: 
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out
 ##########
 @@ -109,64 +109,96 @@ struct<split(aa1cc2ee3, [1-9]+, 2):array<string>>
 
 
 -- !query 13
-SELECT substr('abcdefg', 1)
+SELECT substr('Spark SQL', 5)
 -- !query 13 schema
-struct<substring(abcdefg, 1, 2147483647):string>
+struct<substring(Spark SQL, 5, 2147483647):string>
 -- !query 13 output
-abcdefg
+k SQL
 
 Review comment:
   Thanks! Much better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to