ketank-new commented on a change in pull request #24788: [SPARK-26985][CORE]
Fix "access only some column of the all of columns " for big endian architecture
URL: https://github.com/apache/spark/pull/24788#discussion_r291956881
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
##########
@@ -51,6 +51,8 @@
// Since java.nio.Bits.unaligned() doesn't return true on ppc (See
JDK-8165231), but
// ppc64 and ppc64le support it
_unaligned = true;
+ } else if (arch.matches("s390x")) {
Review comment:
@srowen : did not get your <.contains> comment what exactly you are trying
to say
I have intentionally written a else if blk to keep processor specific
changes in seperate block.
are you asking me to add "s390x" in the same "ppc64le" blk ... let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
