zsxwing commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies URL: https://github.com/apache/spark/pull/24490#issuecomment-500514398 IIUC, this looks like just because of the known issue in `mvn checkstyle:check` command (called by lint-java script). It requires all dependencies of a module (even dependencies are just other sub-modules) can be found in the local repo (You can run `mvn install` to install sub-modules) or a remote repo. It's green now because this Jenkins job ( https://amplab.cs.berkeley.edu/jenkins/job/spark-master-maven-snapshots/ ) pushed the artifacts to https://repository.apache.org/content/repositories/snapshots/. Hence maven can download all artifacts of sub-modules from this repo now. In general, the java style check may fail if someone adds multiple maven projects, until the artifacts are pushed to the apache snapshot repo. But this should be fine since that's rare and we push snapshots every day. By the way, I also noticed that java style check is enabled in the PR build now: https://github.com/apache/spark/blob/742f805177e3fafae61a760b570b5bb2825237b3/dev/run-tests.py#L593 This issue may happen in the PR build if a PR also adds Java files which will trigger java style check. Java style check needs to be disabled until the artifacts of this project are pushed to the apache snapshot repo. Not sure where to document this. ( I learnt this issue in one of my old PRs https://github.com/apache/spark/pull/10744#issuecomment-172677275 and disabled the java style check in https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5#diff-9657d18e98a7dc82ca214359cfd6bdc4 )
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
