viirya commented on a change in pull request #24599: [SPARK-27701][SQL] Extend 
NestedColumnAliasing to general nested field cases including GetArrayStructField
URL: https://github.com/apache/spark/pull/24599#discussion_r292235857
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
 ##########
 @@ -31,7 +31,7 @@ import org.apache.spark.sql.types._
 object NestedColumnAliasing {
 
   def unapply(plan: LogicalPlan)
-    : Option[(Map[GetStructField, Alias], Map[ExprId, Seq[Alias]])] = plan 
match {
+    : Option[(Map[ExtractValue, Alias], Map[ExprId, Seq[Alias]])] = plan match 
{
     case Project(projectList, child)
         if SQLConf.get.nestedSchemaPruningEnabled && 
canProjectPushThrough(child) =>
 
 Review comment:
   Oh, I see. Then I will change the default value to `true` and see if all 
tests can pass. Before merging, we can revert it back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to