skonto commented on a change in pull request #24702: [SPARK-27989] [Kubernetes] 
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r292404320
 
 

 ##########
 File path: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile
 ##########
 @@ -51,6 +51,8 @@ ENV SPARK_HOME /opt/spark
 
 WORKDIR /opt/spark/work-dir
 RUN chmod g+w /opt/spark/work-dir
+#Disable negative dns reslolution 
https://docs.oracle.com/javase/8/docs/technotes/guides/net/properties.html
+RUN sed -i -e 
's/networkaddress.cache.negative.ttl=10/networkaddress.cache.negative.ttl=0/g'  
/usr/lib/jvm/java-1.8-openjdk/jre/lib/security/java.security
 
 Review comment:
   @jlpedrosa
   >  I saw the option of sending the whole file, I thought it was too 
complicated for people, and I think this issue is mostly present in K8s.
   
   I am not saying to send the whole the file, that is one option, user could 
just create it on the fly in his entrypoint script based on env vars or do the 
`sed` in there based on the env vars. In my custom image for example I have a 
Prometheus config file that works for all my deployments, users in a slow env 
may even choose to have these security properties predefined in the file in the 
image. I dont see why you need to hardcode them in the Dockerfile, it is 
restrictive. 
   Btw the dockerfile you are modifying is about k8s only so what you modify it 
affects that only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to