srowen commented on a change in pull request #24807: [SPARK-27958][SQL]
Stopping a SparkSession should not always stop Spark Context
URL: https://github.com/apache/spark/pull/24807#discussion_r292439923
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -981,17 +988,27 @@ object SparkSession extends Logging {
* @since 2.0.0
*/
def setActiveSession(session: SparkSession): Unit = {
- activeThreadSession.set(session)
+ if (getActiveSession.isEmpty
+ || (session != getActiveSession.get && getActiveSession.isDefined)) {
Review comment:
`.isDefined` is checked in the wrong order, but you've already checked it
actually with `.isEmpty`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
