gengliangwang commented on a change in pull request #24043: [SPARK-11412][SQL]
Support merge schema for ORC
URL: https://github.com/apache/spark/pull/24043#discussion_r292468830
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaSuite.scala
##########
@@ -134,6 +135,31 @@ class VectorizedOrcReadSchemaSuite
}
}
+class MergedOrcReadSchemaSuite
+ extends ReadSchemaSuite
+ with AddColumnIntoTheMiddleTest
+ with HideColumnInTheMiddleTest
+ with AddNestedColumnTest
+ with HideNestedColumnTest
+ with ChangePositionTest
+ with BooleanTypeTest
+ with IntegralTypeTest
+ with ToDoubleTypeTest {
+
+ override val format: String = "orc"
+
Review comment:
We can use
```
override protected def sparkConf: SparkConf =
super
.sparkConf
.set(...)
```
And drop the `beforeAll` and `afterAll`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
