srowen opened a new pull request #24843: [SPARK-28004][UI] 
URL: https://github.com/apache/spark/pull/24843
 
 
   ## What changes were proposed in this pull request?
   
   We're using an old-ish jQuery, 1.12.4, and should probably update for Spark 
3 to keep up in general, but also to keep up with CVEs. In fact, we know of at 
least one resolved in only 3.4.0+ 
(https://nvd.nist.gov/vuln/detail/CVE-2019-11358). They may not affect Spark, 
but, if the update isn't painful, maybe worthwhile in order to make future 3.x 
updates easier.
   
   jQuery 1 -> 2 doesn't sound like a breaking change, as 2.0 is supposed to 
maintain compatibility with 1.9+ 
(https://blog.jquery.com/2013/04/18/jquery-2-0-released/)
   
   2 -> 3 has breaking changes: https://jquery.com/upgrade-guide/3.0/. It's 
hard to evaluate each one, but the most likely area for problems is in ajax(). 
However, our usage of jQuery (and plugins) is pretty simple.
   
   Update jquery to 3.4.1; update jquery blockUI and mustache to latest
   
   ## How was this patch tested?
   
   Manual testing of docs build (except R docs), worker/master UI, spark 
application UI.
   Note: this really doesn't guarantee it works, as our tests can't test 
javascript, and this is merely anecdotal testing, although I clicked about 
every link I could find. There's a risk this breaks a minor part of the UI; it 
does seem to work fine in the main.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to