jzhuge commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2 table relation
URL: https://github.com/apache/spark/pull/24741#discussion_r292633197
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##########
@@ -295,10 +295,16 @@ package object dsl {
object expressions extends ExpressionConversions // scalastyle:ignore
object plans { // scalastyle:ignore
- def table(ref: String): LogicalPlan =
UnresolvedRelation(TableIdentifier(ref))
+ def table(parts: String*): LogicalPlan = UnresolvedRelation(parts)
- def table(db: String, ref: String): LogicalPlan =
- UnresolvedRelation(TableIdentifier(ref, Option(db)))
+ // Cannot use the name `with` since it is reserved
Review comment:
It is now used by 2 test cases, so it will have to be moved out of the test
case into test suite. I am ok with that, although this convenience function
seem generic enough to go into dsl/package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
