mengxr commented on a change in pull request #24855: [SPARK-28030] convert
filePath to URI in binary file data source
URL: https://github.com/apache/spark/pull/24855#discussion_r293008850
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
##########
@@ -368,4 +368,14 @@ class BinaryFileFormatSuite extends QueryTest with
SharedSQLContext with SQLTest
assert(caught.getMessage.contains("exceeds the max length allowed"))
}
}
+
+ test("SPARK-28030: support chars in file names that require URL encoding") {
Review comment:
it still relies on each data source implementation to recognize `filePath`
is actually an URI. I don't see how to test it in our root datasource test.
Btw, this PR adds a regression test. So I want to keep the scope minimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
