dacort commented on a change in pull request #24618: [SPARK-27734][CORE][SQL]
Add memory based thresholds for shuffle spill
URL: https://github.com/apache/spark/pull/24618#discussion_r293026168
##########
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
##########
@@ -396,9 +406,14 @@ public void insertRecord(
logger.info("Spilling data because number of spilledRecords crossed the
threshold " +
numElementsForSpillThreshold);
spill();
- }
+ } else if (inMemRecordsSize >= maxRecordsSizeForSpillThreshold) {
+ logger.info("Spilling data because size of spilledRecords crossed the
threshold " +
Review comment:
Indentation got changed up here through `growPointerArrayIfNecessary` on
line 416 below. Needs to be re-indented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
