rdblue commented on a change in pull request #24806: [WIP][SPARK-27856][SQL]
Only allow type upcasting when inserting table
URL: https://github.com/apache/spark/pull/24806#discussion_r293072530
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -290,15 +290,14 @@ abstract class DataSourceV2AnalysisSuite extends
AnalysisTest {
StructField("y", DoubleType))).toAttributes)
val query = TestRelation(StructType(Seq(
- StructField("x", DoubleType),
+ StructField("x", FloatType),
Review comment:
No, all errors should be reported. Attempting to write a double to a float
column is an error that should be shown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
