dongjoon-hyun commented on a change in pull request #24741: [SPARK-27322][SQL] DataSourceV2 table relation URL: https://github.com/apache/spark/pull/24741#discussion_r293129277
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ########## @@ -657,6 +659,20 @@ class Analyzer( } } + /** + * Resolve table relations with concrete relations from v2 catalog. + * + * [[ResolveRelations]] still resolves v1 tables. + */ + object ResolveTables extends Rule[LogicalPlan] { Review comment: ~Can we use `ResolveV2Relations` instead in order to avoid those confusion?~ ```scala - * Resolve table relations with concrete relations from v2 catalog. - * - * [[ResolveRelations]] still resolves v1 tables. + * Replaces [[UnresolvedRelation]]s with concrete relations from the v2 catalog. */ - object ResolveTables extends Rule[LogicalPlan] { + object ResolveV2Relations extends Rule[LogicalPlan] { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org