imback82 commented on issue #24857: [MINOR][CORE] Remove an unused variable in 
SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#issuecomment-501510491
 
 
   > * We use `[MINOR]` tag if we don't have SPARK JIRAs.
   
   Thanks. I will follow this from the next PR.
   
   > * Could you find more instances in `core` module? We usually recommend to 
do this kind of tasks module by module.
   
   I compiled with `-Xlint:unused` for the `core` module. I fixed most of the 
warnings for unused local variable and unused imports (there were some false 
positives since scaladoc was referring to the imports). I didn't fix unused 
private variable, private method, and private default arguments; there are 
about 50 of them and I can fix them in a separate PR if needed.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to