Ngone51 commented on a change in pull request #24841: [SPARK-27369][CORE] Setup
resources when Standalone Worker starts up
URL: https://github.com/apache/spark/pull/24841#discussion_r293187804
##########
File path: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala
##########
@@ -60,7 +60,7 @@ class WorkerSuite extends SparkFunSuite with Matchers with
BeforeAndAfter {
val securityMgr = new SecurityManager(conf)
val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
_worker = new Worker(rpcEnv, 50000, 20, 1234 * 5,
Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
- "Worker", "/tmp", conf, securityMgr, shuffleServiceSupplier)
+ "Worker", "/tmp", conf, securityMgr, None, Map.empty,
shuffleServiceSupplier)
Review comment:
We need to get Master in to test wether Worker sets up the resources
correctly, since Worker could not start up without a living Master. Maybe, we
could cover this in the following JIRA task, which would sharing resource info
between Master and Worker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
