dongjoon-hyun commented on a change in pull request #24857: [MINOR][CORE]
Remove an unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293207010
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
##########
@@ -131,13 +129,6 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
return UIUtils.headerSparkPage(request, stageHeader, content, parent)
}
- val storedTasks = store.taskCount(stageData.stageId, stageData.attemptId)
- val numCompleted = stageData.numCompleteTasks
- val totalTasksNumStr = if (totalTasks == storedTasks) {
- s"$totalTasks"
- } else {
- s"$totalTasks, showing $storedTasks"
- }
Review comment:
@imback82 . Before removing lines, please read the commit history. For
example, this is live code. Please see the following PR.
- https://github.com/apache/spark/pull/22525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
